Add placement error code #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lee Fowler <[email protected]>
artursouza
approved these changes
Mar 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
- Coverage 79.93% 79.86% -0.07%
==========================================
Files 56 56
Lines 4351 4351
==========================================
- Hits 3478 3475 -3
- Misses 728 730 +2
- Partials 145 146 +1 ☔ View full report in Codecov by Sentry. |
|
Thank you for the review @artursouza . I was wondering when I can expect to get this PR merged so I can use the Error code in the updated Placement API error handling? At the minute I have made a local const placeholder, but can't merge this into the Dapr repo. Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a prefix error code to the kit to be used in the error handling of the placement api. The error code will be used in the .WithErrorInfo() function to provide detailed information for the placement error api. This PR is related to Error Standardization: Placement API #7490.
Issue reference
This PR will close issue : Add Placement error code #90
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: